-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tfinstall package #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments, non-blocking - otherwise LGTM!
github.com/sergi/go-diff v1.2.0 | ||
github.com/stretchr/testify v1.7.0 | ||
github.com/zclconf/go-cty v1.9.1 | ||
github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b | ||
golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #109.
We now import github.com/hashicorp/hc-install for installing Terraform versions during testing.
Goreleaser config is also removed, to signal that this is a library to be consumed by Go and does not compile to a binary.